llhttp: update to 1.1.2#27513
Closed
indutny wants to merge 1 commit into
Closed
Conversation
Collaborator
cjihrig
approved these changes
May 1, 2019
cjihrig
left a comment
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but the commit message is failing linting. Maybe try deps: update llhttp to 1.1.2.
Trott
approved these changes
May 1, 2019
indutny
force-pushed
the
feature/update-llhttp-1.1.2
branch
from
869f8e8 to
11a9d53
Compare
Member
Author
|
@cjihrig 🤦♂ my bad. Thanks for pointing out! |
trivikr
approved these changes
May 2, 2019
Trott
added
the
author ready
Collaborator
Member
|
Landed in 7467a5d |
targos
pushed a commit
that referenced
this pull request
May 5, 2019
PR-URL: #27513 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 6, 2019
PR-URL: #27513 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passescc @nodejs/http